-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(integrations): Remove offline integration #9456
Conversation
Hi, we can only do this in as part of a major update. |
Yup! I figured as much. I couldn't find anything on how major updates are done. I can target a |
I appreciate the initiative! Let's hold off on this for a bit. Majors are generally a pretty big deal for us and we need to coordinate and plan them quite extensively. It could be a while until we get to this. We might target a major in January. |
v8 stuff is being tracked here: #5194 I added this PR to the list |
Cheers y'all <3 |
Hey, do you mind rebasing this on develop and getting it up to date? Then we'd be good to merge this! 🎉 |
BREAKING CHANGE: Removes the already deprecated offline integration.
dbb5eed
to
783ccac
Compare
@mydea; you got it :) |
Thanks for sticking around! 😄 |
@lforst; How do I know which version this patch lands in? |
This has been removed in v8! So any version after 8.0.0 will not have this anymore. |
Hey! Since the offline integration has been deprecated for almost a year now can we just remove it? It would remove the
localforage
dependency which is a known pain in the ass as a CommonJS module.See #3401.